hcrosse opened a new pull request, #21687: URL: https://github.com/apache/datafusion/pull/21687
## Which issue does this PR close? - Closes #21685. ## Rationale for this change Per issue. `make_valid_utf8.rs` imports from `datafusion::logical_expr`, but `datafusion` is only a dep of `datafusion-spark` behind the `core` feature, so `cargo check -p datafusion-spark` and `cargo bench -p datafusion-spark` both fail without `--all-features`. CI doesn't catch it because `datafusion-sqllogictest` pins `datafusion-spark` with `core` on. ## What changes are included in this PR? Move the `ColumnarValue`, `Signature`, `Volatility` imports from `datafusion::logical_expr` to `datafusion_expr`, which is already imported a few lines below. ## Are these changes tested? Covered by existing tests. Verified `cargo check -p datafusion-spark`, `cargo check -p datafusion-spark --all-targets`, and `cargo bench -p datafusion-spark` all succeed after the change, and `./dev/rust_lint.sh` passes. ## Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
