berkaysynnada commented on code in PR #21473:
URL: https://github.com/apache/datafusion/pull/21473#discussion_r3097388698
##########
datafusion/physical-plan/src/filter.rs:
##########
@@ -2264,78 +2343,252 @@ mod tests {
}
#[tokio::test]
- async fn test_filter_statistics_equality_sets_ndv_to_one() -> Result<()> {
- // a: min=1, max=100, ndv=80
- let schema = Schema::new(vec![Field::new("a", DataType::Int32,
false)]);
- let input = Arc::new(StatisticsExec::new(
- Statistics {
- num_rows: Precision::Inexact(100),
- total_byte_size: Precision::Inexact(400),
- column_statistics: vec![ColumnStatistics {
- min_value: Precision::Inexact(ScalarValue::Int32(Some(1))),
- max_value:
Precision::Inexact(ScalarValue::Int32(Some(100))),
- distinct_count: Precision::Inexact(80),
+ async fn test_filter_statistics_equality_ndv() -> Result<()> {
Review Comment:
I may have missed it, but is there a test for something like` a = 1 AND a =
1 AND b = 2`? Would be nice to have if not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
