alamb commented on code in PR #11615:
URL: https://github.com/apache/datafusion/pull/11615#discussion_r1687859576
##########
datafusion/physical-plan/src/coalesce_batches.rs:
##########
@@ -276,20 +266,6 @@ impl RecordBatchStream for CoalesceBatchesStream {
}
}
-/// Concatenates an array of `RecordBatch` into one batch
-pub fn concat_batches(
- schema: &SchemaRef,
- batches: &[RecordBatch],
- row_count: usize,
-) -> ArrowResult<RecordBatch> {
- trace!(
- "Combined {} batches containing {} rows",
- batches.len(),
- row_count
- );
- arrow::compute::concat_batches(schema, batches)
Review Comment:
The existing function simply wraps `concat_batches` in arrow and logs some
information which I don't think is critical. Note that the `row_count` is only
used for the logging. If reviewers think the `trace!` is valuable, I will put
it back (at the callsites)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
