Dandandan commented on code in PR #11615:
URL: https://github.com/apache/datafusion/pull/11615#discussion_r1687964534
##########
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##########
@@ -364,7 +364,7 @@ async fn collect_left_input(
let stream = merge.execute(0, context)?;
// Load all batches and count the rows
- let (batches, num_rows, metrics, mut reservation) = stream
+ let (batches, _num_rows, metrics, mut reservation) = stream
Review Comment:
`_num_rows` calc can go here now...
##########
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##########
@@ -364,7 +364,7 @@ async fn collect_left_input(
let stream = merge.execute(0, context)?;
// Load all batches and count the rows
- let (batches, num_rows, metrics, mut reservation) = stream
+ let (batches, _num_rows, metrics, mut reservation) = stream
Review Comment:
`_num_rows` calc can be removed here now...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
