kosiew commented on code in PR #21315:
URL: https://github.com/apache/datafusion/pull/21315#discussion_r3099679924
##########
datafusion/functions-aggregate-common/src/min_max.rs:
##########
@@ -413,6 +413,22 @@ macro_rules! min_max {
min_max_generic!(lhs, rhs, $OP)
}
+ (lhs, rhs)
+ if matches!(lhs, ScalarValue::Dictionary(_, _))
+ || matches!(rhs, ScalarValue::Dictionary(_, _)) =>
+ {
Review Comment:
This is a fair callout. The implementation is now intentionally unwrapping
dictionary scalars and comparing their inner logical values, so the
documentation should no longer imply a strict “same variant only” contract
without qualification.
I’ll update the comment to say that `lhs` and `rhs` must still represent
compatible logical values, and that dictionary scalars are compared via their
inner values after validating any dictionary-specific constraints. That keeps
the docs aligned with the new behavior without overstating support for
arbitrary mixed scalar variants.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
