andygrove commented on code in PR #3939:
URL: https://github.com/apache/datafusion-comet/pull/3939#discussion_r3100348266
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -1247,7 +1317,41 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
test("cast TimestampType to StringType") {
- castTest(generateTimestamps(), DataTypes.StringType)
+ // UTC baseline — also exercises fractional-second trailing-zero stripping
+ // and pre-epoch values via generateTimestamps()
+ withSQLConf(SQLConf.SESSION_LOCAL_TIMEZONE.key -> "UTC") {
+ castTest(generateTimestamps(), DataTypes.StringType)
+ }
+ // Spark formats timestamps in the session timezone without tz suffix.
+ // pre_timestamp_cast shifts the UTC value by the session tz offset before
+ // passing to DataFusion, so DST-sensitive timezones must also be correct.
+ compatibleTimezones.foreach { tz =>
+ withSQLConf(SQLConf.SESSION_LOCAL_TIMEZONE.key -> tz) {
+ castTest(generateTimestamps(), DataTypes.StringType)
+ }
+ }
+ }
+
+ test("cast TimestampType to StringType - ancient timestamps") {
Review Comment:
Some of these tests seem unrelated to casting decimal to string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
