andygrove commented on code in PR #3939:
URL: https://github.com/apache/datafusion-comet/pull/3939#discussion_r3100351399
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -1917,7 +2043,12 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
private def roundtripParquet(df: DataFrame, tempDir: File): DataFrame = {
val filename = new File(tempDir,
s"castTest_${System.currentTimeMillis()}.parquet").toString
- df.write.mode(SaveMode.Overwrite).parquet(filename)
+ // CORRECTED mode writes timestamps as proleptic Gregorian without rebase.
+ // Required because generateTimestamps() includes pre-1900 values (e.g.
1900-06-15)
+ // which trigger INT96's default EXCEPTION mode when written with certain
timezones.
+ withSQLConf("spark.sql.parquet.int96RebaseModeInWrite" -> "CORRECTED") {
Review Comment:
Unrelated to the PR goal, may be better in a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
