nathanb9 commented on code in PR #21425:
URL: https://github.com/apache/datafusion/pull/21425#discussion_r3102925304
##########
datafusion/execution/src/memory_pool/mod.rs:
##########
@@ -294,6 +319,7 @@ impl MemoryConsumer {
name: self.name.clone(),
can_spill: self.can_spill,
id: Self::new_unique_id(),
+ reclaimer: self.reclaimer.clone(),
Review Comment:
Ive made clone_with_new_id() explicitly drop the reclaimer. reclaimers are
tied to the original spillable state and shouldn’t follow a new consumer id
makes sense to me. Thanks!
Addressed also I think new: `test_clone_with_new_id_drops_reclaimer` helps
as sanity check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
