nathanb9 commented on code in PR #21425:
URL: https://github.com/apache/datafusion/pull/21425#discussion_r3102941506
##########
datafusion/execution/src/memory_pool/mod.rs:
##########
@@ -307,6 +333,15 @@ impl MemoryConsumer {
Self { can_spill, ..self }
}
+ /// Configure a callback that can reclaim memory from this consumer when
another consumer in
+ /// the same pool is under pressure.
+ pub fn with_reclaimer(self, reclaimer: Arc<dyn MemoryReclaimer>) -> Self {
Review Comment:
Thanks yea this a bit confusing. So instead now: `with_reclaimer(...)` now
sets `can_spill: true` directly.
Also added straight forward note: "A consumer with a reclaimer is considered
spill-capable by default" for clarify
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
