alamb commented on PR #11330: URL: https://github.com/apache/datafusion/pull/11330#issuecomment-2245863417
> Sure -- let's just make sure to avoid API churn and complete the work 🙂 How about we file a ticket explaining what else is needed prior to merging this PR. I can do this but I want to make sure I have the use case down correctly @berkaysynnada says: > What I suggest is that we can let people to define their own normalizations. Rather than directing all values to lowercase, people can declare their own normalization methods for specific option keys. If we choose to do that in this PR, I believe the normalization process should be done during the assignment of table options. The code in https://github.com/synnada-ai/datafusion-upstream/commit/341b48458c09f25d2a5873fcee2fce18eb0e1097 I think seems to show a way to add an annotation to a built in config setting value that controls how it will be normalized. Is the use case to 1. Provide a new set of `ConfigOptions` (not in DataFusion) that have custom normalization rules? 2. Avoid normalization on some of the built in configs? Something else? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
