diegoQuinas commented on PR #21728: URL: https://github.com/apache/datafusion/pull/21728#issuecomment-4276520929
Yes, I think it does. A quick comparison: - **#21455** closes #20273 by adding `FixedSizeBinary` to the min/max exclusion filter, so those columns fall back to `null` in the summary. It leaves `LargeBinary` and `BinaryView` still broken (they hit the `Utf8` cast error). - **This PR** closes #21496 and takes the opposite direction: instead of filtering more types out, it removes `Binary` from the filter and adds a display branch using `arrow::util::display::ArrayFormatter` for `Binary`, `LargeBinary`, `BinaryView`, and `FixedSizeBinary`. Min/max actually render (as lowercase hex) rather than being dropped to `null`. So the `FixedSizeBinary` case #21455 targets is handled here, plus `LargeBinary`/`BinaryView`, and users get real values instead of `null`. Happy to close #21455 in favor of this one if reviewers agree — or, if the `null` fallback is preferred over hex rendering, I can rework this PR on top of #21455. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
