Jefffrey commented on code in PR #21728:
URL: https://github.com/apache/datafusion/pull/21728#discussion_r3115159546
##########
datafusion/core/tests/dataframe/describe.rs:
##########
@@ -112,6 +118,61 @@ async fn describe_null() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async fn describe_binary_columns() -> Result<()> {
+ let schema = Arc::new(Schema::new(vec![
+ Field::new("bin", DataType::Binary, true),
+ Field::new("lbin", DataType::LargeBinary, true),
+ Field::new("vbin", DataType::BinaryView, true),
+ Field::new("fbin", DataType::FixedSizeBinary(2), true),
+ ]));
+
+ let bin: BinaryArray = vec![Some(&[0x00u8, 0x01][..]), Some(&[0xff,
0xee][..]), None]
+ .into_iter()
+ .collect();
+ let lbin: LargeBinaryArray =
+ vec![Some(&[0x00u8, 0x01][..]), Some(&[0xff, 0xee][..]), None]
+ .into_iter()
+ .collect();
+ let vbin: BinaryViewArray =
+ vec![Some(&[0x00u8, 0x01][..]), Some(&[0xff, 0xee][..]), None]
+ .into_iter()
+ .collect();
+ let fbin = FixedSizeBinaryArray::try_from_sparse_iter_with_size(
+ vec![Some(vec![0x00u8, 0x01]), Some(vec![0xff, 0xee]),
None].into_iter(),
+ 2,
+ )?;
Review Comment:
```suggestion
let bin: BinaryArray = vec![Some([0x00u8, 0x01]), Some([0xff, 0xee]),
None]
.into_iter()
.collect();
let lbin: LargeBinaryArray = vec![Some([0x00u8, 0x01]), Some([0xff,
0xee]), None]
.into_iter()
.collect();
let vbin: BinaryViewArray = vec![Some([0x00u8, 0x01]), Some([0xff,
0xee]), None]
.into_iter()
.collect();
let fbin = FixedSizeBinaryArray::try_from_sparse_iter_with_size(
[Some([0x00u8, 0x01]), Some([0xff, 0xee]), None].into_iter(),
2,
)?;
```
Simplification
##########
datafusion/core/src/dataframe/mod.rs:
##########
@@ -1126,14 +1123,37 @@ impl DataFrame {
Arc::new(StringArray::from(vec!["null"]))
} else if field.data_type().is_numeric() {
cast(column, &DataType::Float64)?
+ } else if matches!(
+ field.data_type(),
+ DataType::Binary
Review Comment:
Use
[`is_binary`](https://docs.rs/arrow/latest/arrow/datatypes/enum.DataType.html#method.is_binary)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
