kumarUjjawal commented on PR #21739:
URL: https://github.com/apache/datafusion/pull/21739#issuecomment-4280806158
I tried two approaches for this.
The first approach was by hiding the bit in alias metadata. It fixed the
display problem, but it also mixed planner-only state with user metadata. That
made the behavior harder to reason about and forced extra handling in places
like equality, hashing, serialization, and rewrite logic. In practice, a simple
display fix startedaffecting alias identity and metadata flow in too many
places.
The current approach adds an explicit internal flag to alias. This is a
small API break, but it makes the model much clearer: whether an alias is user
written or planner generated is now part of the type itself, not hidden in
metadata. That keeps the display logic direct, avoids hidden state leaking into
unrelated code paths, and makes future maintenance safer because the intent is
visible and compiler checked.
Would love to hear your thoughts @pepijnve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
