pepijnve commented on code in PR #21739:
URL: https://github.com/apache/datafusion/pull/21739#discussion_r3111019950
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -3769,6 +3924,139 @@ mod tests {
Ok(())
}
+ #[tokio::test]
+ async fn test_aggregate_explain_shows_aliased_expression() -> Result<()> {
Review Comment:
These might be more concise as SLTs
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -561,7 +561,14 @@ impl GroupedHashAggregateStream {
let agg_fn_names = aggregate_exprs
.iter()
- .map(|expr| expr.human_display())
+ .map(|expr| {
+ let human_display = expr.human_display();
+ if human_display.is_empty() {
Review Comment:
Should `human_display` be `Option<String>`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
