cj-zhukov commented on code in PR #21021:
URL: https://github.com/apache/datafusion/pull/21021#discussion_r3128496638
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -1046,26 +1049,28 @@ async fn test_aggregate_with_union() -> Result<()> {
let df1 = df
.clone()
- // GROUP BY `c1`
- .aggregate(vec![col("c1")], vec![min(col("c2"))])?
- // SELECT `c1` , min(c2) as `result`
- .select(vec![col("c1"), min(col("c2")).alias("result")])?;
+ // GROUP BY c1, compute min(c2) as result
+ .aggregate(vec![col("c1")], vec![min(col("c2")).alias("result")])?
Review Comment:
Thanks for raising this. The changes are not introducing a regression in
existing behavior, but they do affect how certain edge cases are handled due to
the new aggregate rewriting logic.
I tried to keep the impact minimal and avoid breaking existing
functionality, but some adjustments in tests were needed to align with the
updated behavior.
The `test_aggregate_with_union` case should still behave correctly, but let
me know if you see a specific scenario where the behavior deviates from
expectations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
