cj-zhukov commented on code in PR #21021: URL: https://github.com/apache/datafusion/pull/21021#discussion_r3130921956
########## datafusion-examples/examples/dataframe/dataframe.rs: ########## @@ -53,8 +55,10 @@ use tokio::fs::create_dir_all; /// /// * [write_out]: write out a DataFrame to a table, parquet file, csv file, or json file /// -/// # Executing subqueries +/// # Querying data /// +/// * [aggregate_global_and_grouped]: global vs grouped aggregation (`select` vs `aggregate`) Review Comment: Thanks for the question. We do have aggregation examples, but I found that there wasn’t a simple, straightforward example demonstrating basic aggregation with the DataFrame API in isolation. While working on this PR, I actually had to search for such an example myself and even asked in the DataFusion Discord for clarification. That suggested there may be a small gap in discoverability for this common use case. The goal of adding these examples is to provide: - a minimal, easy-to-follow aggregation example - a side-by-side illustration of using the aggregate API vs aggregates inside select This should help users better understand the different approaches and choose the one that fits their use case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
