alamb commented on code in PR #11634:
URL: https://github.com/apache/datafusion/pull/11634#discussion_r1689903291
##########
datafusion/sql/src/expr/order_by.rs:
##########
@@ -87,11 +87,9 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
input_schema.qualified_field(field_index - 1),
))
}
- e => self.sql_expr_to_logical_expr(
- e.clone(),
Review Comment:
Here is the clone that is avoided.
##########
datafusion/sql/src/expr/order_by.rs:
##########
@@ -37,7 +37,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
/// If false, interpret numeric literals as constant values.
pub(crate) fn order_by_to_sort_expr(
&self,
- exprs: &[OrderByExpr],
+ exprs: Vec<OrderByExpr>,
Review Comment:
the API changes to take the owned `Vec` rather than a slice
##########
datafusion/sql/src/expr/order_by.rs:
##########
@@ -37,7 +37,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
/// If false, interpret numeric literals as constant values.
pub(crate) fn order_by_to_sort_expr(
&self,
- exprs: &[OrderByExpr],
+ exprs: Vec<OrderByExpr>,
Review Comment:
The internal API changes to take the owned `Vec` rather than a slice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
