fred1268 commented on code in PR #21825:
URL: https://github.com/apache/datafusion/pull/21825#discussion_r3147250469
##########
datafusion/datasource-parquet/src/file_format.rs:
##########
@@ -1339,8 +1375,10 @@ impl FileSink for ParquetSink {
.with_category(MetricCategory::Bytes)
.global_counter("bytes_written");
let elapsed_compute =
MetricBuilder::new(&self.metrics).elapsed_compute(0);
-
- let write_start = datafusion_common::instant::Instant::now();
+ // Sequential path only: not registered in MetricsSet — used
internally to
+ // compute elapsed_compute = total_write_time - io_time.
+ let total_write_time = Time::new();
+ let io_time = Time::new();
Review Comment:
This is indeed a good idea. I implemented your `datafusion-distributed`
proposal as consistently as possible. Let me know if this is not what you had
in mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
