andygrove opened a new pull request, #21960:
URL: https://github.com/apache/datafusion/pull/21960
## Which issue does this PR close?
- Closes #.
## Rationale for this change
Several follow-on PRs need access to `SparkSqlDialect`, which has been merged
to `apache/datafusion-sqlparser-rs` main but is not yet in a published
release.
Pinning to a git rev unblocks that work without waiting for the next
sqlparser
release.
## What changes are included in this PR?
- Bump workspace `sqlparser` from crates.io `0.61.0` to git rev
`9833c033bc44c487b4425272cc8cea80971b5239` (apache/datafusion-sqlparser-rs
main).
- Adapt `datafusion-sql` and `datafusion-expr` to upstream AST changes
accumulated
over the ~2 month gap. Where new AST variants/fields are not currently
supported,
the SQL frontend rejects them with `not_impl_err!` / `plan_err!` rather
than
silently accepting. Notable areas: `Insert::columns: Vec<ObjectName>`,
`Lambda::params: OneOrManyWithParens<LambdaFunctionParameter>`, new
`SelectItem::ExprWithAliases`, `BeginTransactionKind::Tran`,
`TableConstraint::PrimaryKeyUsingIndex`/`UniqueUsingIndex`, new
`CreateTable`
fields (`snapshot`, `diststyle`, `distkey`, `sortkey`, `backup`,
`with_storage_lifecycle_policy`), `CreateView::copy_grants`,
`Insert/Update/Delete::output`, `Update::order_by`,
`TableObject::TableQuery`,
`WildcardAdditionalOptions::opt_alias`, `CREATE FUNCTION RETURNS SETOF`,
`Parens<Vec<Expr>>` around VALUES rows, `escape_char:
Option<ValueWithSpan>`,
`ExcludeSelectItem::Single/Multiple` carrying `ObjectName`.
- One golden-file update in `sqllogictest/test_files/higher_order.slt` for an
upstream error-string change.
## Are these changes tested?
Covered by existing tests. `cargo test --workspace --exclude
datafusion-benchmarks`
passes apart from failures pre-existing on main (datafusion-cli insta
snapshots,
`encrypted_parquet.slt`, `tracing::test_tracer_injection`) which are
unrelated to
this bump.
## Are there any user-facing changes?
No public API changes. New SQL syntax accepted by upstream sqlparser is
rejected
with clear `not_impl_err!` messages; supporting any of them is follow-on
work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
