alamb commented on code in PR #11478:
URL: https://github.com/apache/datafusion/pull/11478#discussion_r1693216328
##########
datafusion/physical-plan/src/repartition/mod.rs:
##########
@@ -415,7 +415,7 @@ struct RepartitionMetrics {
/// Time in nanos to execute child operator and fetch batches
fetch_time: metrics::Time,
/// Time in nanos to perform repartitioning
- repartition_time: metrics::Time,
+ repart_time: metrics::Time,
Review Comment:
My rationale was so that the field name matched the display name of this
metric (which is `repart_time`)
(a few [lines down
](https://github.com/apache/datafusion/pull/11478/files#diff-0886bee029ab49ae97b48450576c44717fd0300d8cff9edcde6308f1a40e0c3eR437)
from here)
Another potential would be to rename the metric to `"repartition_time"`
which would be a user facing change (which is probably fine).
I think it would be nice to have them consistent. The exact value I have
less of an opinion of
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
