rluvaton commented on PR #21323: URL: https://github.com/apache/datafusion/pull/21323#issuecomment-4389061859
> In [(earlier comment)](https://github.com/apache/datafusion/pull/21323#discussion_r3178376257) @rluvaton mentioned > > > PhysicalExpr usually don't know the schema on creation which mean that now the API is a little weird > > and above there's a statement that > > > we need the outer schema, which is not always present during physical expr creation > > As far as I can tell, the schema _is_ available during physical planning though. Do you guys know what the situations are where the schema is not available? Or if it's always available in practice, why it's never passed to the physical expression construction functions? Is it simply because there was never a need to or is there some other design constraint? > > I'm asking because I struggled with the same problem when I was working on the case projection code. I had considered passing the schema to the case construction functions, but refrained from doing so to not introduce a backwards incompatible change. Good question, maybe you can trace to the original pr that added it for the reason -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
