gstvg commented on PR #21323: URL: https://github.com/apache/datafusion/pull/21323#issuecomment-4395119486
@rluvaton both comments addressed, thanks for your review @pepijnve some expressions have two constructors, one that do receives the schema and another that don't ([ScalarFunction](https://docs.rs/datafusion/latest/datafusion/physical_expr/struct.ScalarFunctionExpr.html)), and some have only one constructor which requires a schema ([AsyncFunc](https://docs.rs/datafusion/latest/datafusion/physical_expr/async_scalar_function/struct.AsyncFuncExpr.html#method.try_new)). My best guess is like you said, some expressions like case didn't required it at first and now changing it would be breaking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
