nuno-faria commented on code in PR #22031:
URL: https://github.com/apache/datafusion/pull/22031#discussion_r3196594464
##########
datafusion/datasource-parquet/src/page_filter.rs:
##########
@@ -230,19 +234,31 @@ impl PagePruningAccessPlanFilter {
file_metrics,
);
- let Some((selection, total_pages, matched_pages)) = selection
else {
+ let Some((selection, pages)) = selection else {
trace!("No pages pruned in prune_pages_in_one_row_group");
continue;
};
- total_pages_select += matched_pages;
- total_pages_skip += total_pages - matched_pages;
debug!(
"Use filter and page index to create RowSelection {:?}
from predicate: {:?}",
&selection,
predicate.predicate_expr(),
);
+ total_pages_in_group = pages.len();
Review Comment:
I thought returning 0 was expected, as it meant that the page index was not
used. This is the same behavior as the number of rows.
If it's not supposed to be 0 I think it's better to leave as a follow up,
since the number of rows also needs to be fixed. Any thoughts @2010YOUY01?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
