adriangb commented on code in PR #22031:
URL: https://github.com/apache/datafusion/pull/22031#discussion_r3196639206
##########
datafusion/datasource-parquet/src/page_filter.rs:
##########
@@ -230,19 +234,31 @@ impl PagePruningAccessPlanFilter {
file_metrics,
);
- let Some((selection, total_pages, matched_pages)) = selection
else {
+ let Some((selection, pages)) = selection else {
trace!("No pages pruned in prune_pages_in_one_row_group");
continue;
};
- total_pages_select += matched_pages;
- total_pages_skip += total_pages - matched_pages;
debug!(
"Use filter and page index to create RowSelection {:?}
from predicate: {:?}",
&selection,
predicate.predicate_expr(),
);
+ total_pages_in_group = pages.len();
Review Comment:
Yes this is the same behavior as other metrics. I've found this behavior
confusing. This seemed like a case where there's no good reason for this to be
the case. I do agree it should be a followup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
