diegoQuinas commented on code in PR #21710:
URL: https://github.com/apache/datafusion/pull/21710#discussion_r3197922436
##########
datafusion/spark/src/function/math/ceil.rs:
##########
@@ -69,7 +90,12 @@ impl ScalarUDFImpl for SparkCeil {
}
fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> {
+ let has_scale = arg_types.len() == 2;
+
match &arg_types[0] {
+ // 2-arg decimal is not yet supported; report input type so the
planner
+ // does not reject the call before we surface a proper error at
execution.
+ DataType::Decimal128(p, s) if has_scale =>
Ok(DataType::Decimal128(*p, *s)),
Review Comment:
Okay, I will add this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
