github-actions[bot] commented on PR #21710: URL: https://github.com/apache/datafusion/pull/21710#issuecomment-4393735541
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-spark v53.1.0 (current) Built [ 56.111s] (current) Parsing datafusion-spark v53.1.0 (current) Parsed [ 0.057s] (current) Building datafusion-spark v53.1.0 (baseline) Built [ 54.025s] (baseline) Parsing datafusion-spark v53.1.0 (baseline) Parsed [ 0.057s] (baseline) Checking datafusion-spark v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.300s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure function_parameter_count_changed: pub fn parameter count changed --- Description: A publicly-visible function now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_parameter_count_changed.ron Failed in: datafusion_spark::function::math::expr_fn::ceil now takes 2 parameters instead of 1, in /home/runner/work/datafusion/datafusion/datafusion/spark/src/function/math/mod.rs:57 datafusion_spark::expr_fn::ceil now takes 2 parameters instead of 1, in /home/runner/work/datafusion/datafusion/datafusion/spark/src/function/math/mod.rs:57 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 112.657s] datafusion-spark Building datafusion-sqllogictest v53.1.0 (current) Built [ 136.722s] (current) Parsing datafusion-sqllogictest v53.1.0 (current) Parsed [ 0.022s] (current) Building datafusion-sqllogictest v53.1.0 (baseline) Built [ 135.877s] (baseline) Parsing datafusion-sqllogictest v53.1.0 (baseline) Parsed [ 0.023s] (baseline) Checking datafusion-sqllogictest v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.086s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 275.360s] datafusion-sqllogictest ``` </details> <!-- semver-check-comment --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
