andygrove opened a new pull request, #4253: URL: https://github.com/apache/datafusion-comet/pull/4253
## Summary - Modulo expression now emits `REMAINDER_BY_ZERO` instead of `DIVIDE_BY_ZERO`, matching Spark 4.1's new error class - On Spark < 4.1 (where `REMAINDER_BY_ZERO` doesn't exist), the JVM shim maps it back to `DIVIDE_BY_ZERO` - Removes `assume(!isSpark41Plus)` from 4 tests that now pass on all Spark versions ## Test plan - [x] `CometExpressionSuite` "remainder function" passes on Spark 3.5, 4.0, and 4.1 - [x] `CometCastSuite` "cast FloatType to TimestampType", "cast DoubleType to TimestampType", "cast ArrayType to ArrayType" pass on Spark 4.1 - [x] Rust unit tests pass (`cargo test -- modulo`) Closes #4098 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
