mbutrovich commented on code in PR #22051: URL: https://github.com/apache/datafusion/pull/22051#discussion_r3198198218
########## datafusion/functions-window/src/ntile.rs: ########## Review Comment: I think we need a guard for the unsigned path to match the signed path below for n == 0. The new code will panic if n is 0 in the unsigned case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
