comphead commented on PR #22051: URL: https://github.com/apache/datafusion/pull/22051#issuecomment-4398669506
> is dead code then? We should remove it if it's not possible and replace with a `debug_assert` to make the invariant enforced in testing and invisible in release builds. The evaluator can be simplified, however it is the existing code, thanks for helping to make it cleaner. Addressed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
