adriangb commented on PR #22027: URL: https://github.com/apache/datafusion/pull/22027#issuecomment-4402298230
@pepijnve good question. The honest answer is that I don't like relaxing the precondition, and I'm not familiar enough with this part of the code to be 100% sure it will not cause any issues. My only argument (which I do think is a strong one) for this being mostly a theoretical concern is that the existing add and subtract operations already Interval::add and Interval::sub already handled this via BinaryTypeCoercer and thus would have suffered from the same type mismatch problem. Since there have been no issues reported about this afaik maybe it's safe to assume it's a theoretical problem? In other words: this PR is just making the behavior uniform, not introducing new behavior. I do worry that this statistics / constraint solving should not be crashing queries, we should fail gracefully and proceed without this info. I opened #22028 to track that, but it's beyond the scope of this fix I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
