kazuyukitanimura commented on PR #718: URL: https://github.com/apache/datafusion-comet/pull/718#issuecomment-2253833279
@andygrove ``` bit_util/get_value/i32_num_bits_8 time: [781.53 ps 797.98 ps 818.12 ps] change: [-14.395% -11.959% -9.4057%] (p = 0.00 < 0.05) Performance has improved. bit_util/get_value/i32_num_bits_32 time: [599.30 ps 605.37 ps 613.10 ps] change: [-21.472% -14.798% -7.3131%] (p = 0.00 < 0.05) Performance has improved. Found 13 outliers among 100 measurements (13.00%) 13 (13.00%) high mild bit_util/read_u64 time: [662.74 ps 667.79 ps 675.09 ps] change: [-44.346% -43.866% -43.140%] (p = 0.00 < 0.05) Performance has improved. Found 4 outliers among 100 measurements (4.00%) 2 (2.00%) high mild 2 (2.00%) high severe bit_util/read_u32 time: [640.71 ps 641.86 ps 643.37 ps] change: [-84.385% -84.321% -84.263%] (p = 0.00 < 0.05) Performance has improved. Found 15 outliers among 100 measurements (15.00%) 4 (4.00%) high mild 11 (11.00%) high severe bit_util/get_u32_value time: [2.0853 ms 2.0860 ms 2.0868 ms] change: [-28.295% -28.107% -27.945%] (p = 0.00 < 0.05) Performance has improved. Found 2 outliers among 100 measurements (2.00%) 2 (2.00%) high mild ``` The baseline of `read_u64(...)`/`read_u32(...)` are `read_num_bytes_u64(8, ...)`/`read_num_bytes_u32(4, ...)` Reverted the changes for `trailing_bits` as no significant differences are observed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org