comphead commented on code in PR #718:
URL: https://github.com/apache/datafusion-comet/pull/718#discussion_r1700739024
##########
native/core/src/common/bit.rs:
##########
@@ -1019,6 +1033,12 @@ mod tests {
}
}
+ #[test]
+ fn test_read_u64() {
+ let buffer: Vec<u8> = vec![0, 1, 2, 3, 4, 5, 6, 7];
Review Comment:
why is it u8 if we test u64, should we create a vector of i64?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
