goldmedal commented on code in PR #11681:
URL: https://github.com/apache/datafusion/pull/11681#discussion_r1693934130
##########
datafusion/sql/src/select.rs:
##########
@@ -590,44 +589,35 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
if empty_from {
return plan_err!("SELECT * with no tables specified is not
valid");
}
- // do not expand from outer schema
- let expanded_exprs =
- expand_wildcard(plan.schema().as_ref(), plan,
Some(&options))?;
// If there is a REPLACE statement, replace that column with
the given
// replace expression. Column name remains the same.
if let Some(replace) = options.opt_replace {
Review Comment:
I'm considering how to handle the `replace` syntax. I think maybe we can
pass `WildcardAdditionalOptions` to `Expr::Wildcard` and also plan it in the
analyzer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
