jayzhan211 commented on code in PR #11681: URL: https://github.com/apache/datafusion/pull/11681#discussion_r1715186654
########## datafusion/sqllogictest/test_files/window.slt: ########## @@ -3929,7 +3929,11 @@ b 1 3 a 1 4 b 5 5 -statement error DataFusion error: Error during planning: Projection references non-aggregate values: Expression aggregate_test_100.c1 could not be resolved from available columns: rn +# expected failed message: +# DataFusion error: expand_wildcard_rule +# caused by +# Schema error: No field named aggregate_test_100.c1. Valid fields are rn. +statement error Review Comment: I think leaving `Schema error: No field named aggregate_test_100.c1. Valid fields are rn.` is good enough ########## datafusion/sqllogictest/test_files/window.slt: ########## @@ -3929,7 +3929,11 @@ b 1 3 a 1 4 b 5 5 -statement error DataFusion error: Error during planning: Projection references non-aggregate values: Expression aggregate_test_100.c1 could not be resolved from available columns: rn +# expected failed message: +# DataFusion error: expand_wildcard_rule +# caused by +# Schema error: No field named aggregate_test_100.c1. Valid fields are rn. +statement error Review Comment: I think leaving `Schema error: No field named aggregate_test_100.c1. Valid fields are rn.` (the reason why this test fail) is good enough -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
