andygrove commented on code in PR #1651:
URL:
https://github.com/apache/datafusion-ballista/pull/1651#discussion_r3213484679
##########
ballista/client/tests/context_checks.rs:
##########
@@ -39,6 +39,28 @@ mod supported {
crate::common::example_test_data()
}
+ /// Concatenate the `plan` column of an EXPLAIN result into a single
+ /// string for substring assertions.
+ fn plan_text(batches: &[RecordBatch]) -> String {
Review Comment:
Good call, switched to pretty_format_batches in 627e1521. The substring
checks for SortMergeJoinExec/HashJoinExec still work against the formatted
output, and we drop the custom helper.
I also tried walking the physical plan tree directly to avoid string
matching entirely, but that meant bypassing BallistaQueryPlanner and planning
locally with DefaultPhysicalPlanner. That tests DataFusion respects
prefer_hash_join rather than that Ballista does, so I reverted. EXPLAIN
actually round-trips through the scheduler in the remote case, which is what we
want for this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
