Rich-T-kid commented on PR #21765: URL: https://github.com/apache/datafusion/pull/21765#issuecomment-4420844268
the tpch_sp1/sp10 and click house benchmarks dont include dictionary encoded columns, so they aren't benchmarking anything thats included in this PR. ( as @Dandandan mentioned [here](https://github.com/apache/datafusion/pull/21765#issuecomment-4301675954)) benchmarks that include dictionary columns exist in `benchmarks/src/dict` which is run with `/benchmarks/bench.sh run dict` & micro benchmarks that exist in `datafusion/physical-plan/benches/dictionary_group_values.rs`. Im not sure what the command is to run these specific benchmarks through @/adriangbot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
