comphead commented on code in PR #4285:
URL: https://github.com/apache/datafusion-comet/pull/4285#discussion_r3221040750
##########
.github/workflows/spark_sql_test.yml:
##########
@@ -172,12 +169,18 @@ jobs:
cd apache-spark
rm -rf /root/.m2/repository/org/apache/parquet # somehow parquet
cache requires cleanups
NOLINT_ON_COMPILE=true ENABLE_COMET=true ENABLE_COMET_ONHEAP=true
COMET_PARQUET_SCAN_IMPL=${{ matrix.config.scan-impl }}
ENABLE_COMET_LOG_FALLBACK_REASONS=${{ github.event.inputs.collect-fallback-logs
|| 'false' }} \
- build/sbt -Dsbt.log.noformat=true -mem 6144 ${{
matrix.module.args1 }} "${{ matrix.module.args2 }}"
+ build/sbt -Dsbt.log.noformat=true -mem $SBT_MEM ${{
matrix.module.args1 }} "${{ matrix.module.args2 }}"
if [ "${{ github.event.inputs.collect-fallback-logs }}" = "true" ];
then
find . -type f -name "unit-tests.log" -print0 | xargs -0 grep -h
"Comet cannot accelerate" | sed 's/.*Comet cannot accelerate/Comet cannot
accelerate/' | sort -u > fallback.log
fi
env:
LC_ALL: "C.UTF-8"
+ # Standard GitHub runners have 7 GB RAM; cap SBT heap so forked test
+ # JVMs fit alongside it.
+ SBT_MEM: "3072"
+ # Disable parallel test execution to reduce peak memory usage —
+ # mirrors what apache/spark does on GitHub Actions.
+ SERIAL_SBT_TESTS: "1"
Review Comment:
👍 this probably is the fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
