abhinavgautam01 commented on code in PR #1693:
URL:
https://github.com/apache/datafusion-ballista/pull/1693#discussion_r3225941238
##########
ballista/scheduler/src/state/execution_graph.rs:
##########
@@ -1348,6 +1348,10 @@ impl ExecutionGraph for StaticExecutionGraph {
/// fail job with error message
fn fail_job(&mut self, error: String) {
+ // Match `succeed_job`: record wall-clock end time so job metadata and
REST consumers
Review Comment:
no, removed it for the same reason; the behaviour is self-explanatory and
the new test documents the invariant....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
