abhinavgautam01 commented on PR #1693: URL: https://github.com/apache/datafusion-ballista/pull/1693#issuecomment-4429999291
> maybe we should also set the `end_time` in case of job failure ? added test_fail_job_sets_end_time_and_failed_metadata in ballista/scheduler/src/state/execution_graph.rs: it calls ExecutionGraph::fail_job on a StaticExecutionGraph, checks the job is Failed with the expected message, that end_time is set and >= start_time, and that FailedJob.started_at / FailedJob.ended_at match the graph’s times.... AdaptiveExecutionGraph::fail_job still mirrors the same two lines (end_time = timestamp_millis() + status); this test locks in the behaviour for the trait contract used by both paths.... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
