andygrove commented on PR #4239: URL: https://github.com/apache/datafusion-comet/pull/4239#issuecomment-4431451950
@mbutrovich I'm going to start reviewing your PR, but it is 7k LOC and there is lot in there so it may take some time. I have a couple of questions: 1. Is there any reason to block merging this PR to provide the regexp support now (as an experimental feature, gated on a config), and then update the UDF implementations later to use the new framework? 2. Can your PR be broken down into smaller units of work for easier review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
