andygrove commented on PR #4239: URL: https://github.com/apache/datafusion-comet/pull/4239#issuecomment-4431797181
> That does raise the issue of how aggressively I should review these if they'll be dead code soon. There are number of optimizations we're leaving on the table, but maybe that doesn't matter right now. My argument for allowing this PR in would be that it adds all the regression tests and gives us an immediate performance win today. The refactor to update the UDF implementations to use the new framework should be a net reduction in line count I am assuming and easy to review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
