adriangb commented on code in PR #22026:
URL: https://github.com/apache/datafusion/pull/22026#discussion_r3235447056
##########
datafusion/datasource-parquet/src/opener.rs:
##########
@@ -145,11 +153,18 @@ pub(crate) fn build_virtual_columns_state(
if virtual_columns.is_empty() {
return Ok(None);
}
- if pushdown_filters && let Some(predicate) = predicate {
- validate_predicate_does_not_reference_virtual_columns(
+ if cfg!(debug_assertions)
+ && pushdown_filters
Review Comment:
My point was more that we should *also* exclude these in the pushdown phase.
I'm okay with also erroring here in release mode, although would prefer an
error to a panic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
