alamb commented on code in PR #22024:
URL: https://github.com/apache/datafusion/pull/22024#discussion_r3229553534
##########
datafusion/datasource-parquet/src/opener.rs:
##########
@@ -136,6 +136,9 @@ pub(super) struct ParquetMorselizer {
pub max_predicate_cache_size: Option<usize>,
/// Whether to read row groups in reverse order
pub reverse_row_groups: bool,
+ /// Sampling config carried from `ParquetSource`. Applied lazily
+ /// inside the opener once the parquet metadata is available.
+ pub sampling: crate::sampling::ParquetSampling,
Review Comment:
can we use the normal `ParquetSampling` syntax here rather than the fully
qualified `crate::sampling::ParquetSampling`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
