benbellick commented on code in PR #21193:
URL: https://github.com/apache/datafusion/pull/21193#discussion_r3236427447
##########
datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:
##########
@@ -774,7 +774,7 @@ impl DefaultSubstraitLambdaConsumer {
let Some(var) = lambda_parameters.get(field_idx) else {
return substrait_err!(
- "No lambda field at index {field_idx}, got only {}",
+ "At lambda {steps_out} steps out, no field at index
{field_idx}, got only {}",
Review Comment:
nice improved error msg!
##########
datafusion/substrait/tests/cases/serialize.rs:
##########
@@ -390,4 +313,49 @@ mod tests {
.await?;
Ok(ctx)
}
+
+ fn collect_lambda_ref(
Review Comment:
Might be nice to put a comment here just to make it obvious to future
readers what exactly this is doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
