github-actions[bot] commented on PR #21882: URL: https://github.com/apache/datafusion/pull/21882#issuecomment-4443969061
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-execution v53.1.0 (current) Built [ 31.198s] (current) Parsing datafusion-execution v53.1.0 (current) Parsed [ 0.028s] (current) Building datafusion-execution v53.1.0 (baseline) Built [ 29.854s] (baseline) Parsing datafusion-execution v53.1.0 (baseline) Parsed [ 0.027s] (baseline) Checking datafusion-execution v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.288s] 222 checks: 220 pass, 2 fail, 0 warn, 30 skip --- failure auto_trait_impl_removed: auto trait no longer implemented --- Description: A public type has stopped implementing one or more auto traits. This can break downstream code that depends on the traits being implemented. ref: https://doc.rust-lang.org/reference/special-types-and-traits.html#auto-traits impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/auto_trait_impl_removed.ron Failed in: type DiskManagerBuilder is no longer UnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/execution/src/disk_manager.rs:40 type DiskManagerBuilder is no longer RefUnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/execution/src/disk_manager.rs:40 type DiskManager is no longer UnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/execution/src/disk_manager.rs:196 type DiskManager is no longer UnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/execution/src/disk_manager.rs:196 type DiskManagerMode is no longer UnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/execution/src/disk_manager.rs:125 type DiskManagerMode is no longer RefUnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/execution/src/disk_manager.rs:125 --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/enum_variant_added.ron Failed in: variant DiskManagerMode:Custom in /home/runner/work/datafusion/datafusion/datafusion/execution/src/disk_manager.rs:137 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 62.833s] datafusion-execution Building datafusion-physical-plan v53.1.0 (current) Built [ 32.534s] (current) Parsing datafusion-physical-plan v53.1.0 (current) Parsed [ 0.132s] (current) Building datafusion-physical-plan v53.1.0 (baseline) Built [ 33.547s] (baseline) Parsing datafusion-physical-plan v53.1.0 (baseline) Parsed [ 0.133s] (baseline) Checking datafusion-physical-plan v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.788s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 68.824s] datafusion-physical-plan ``` </details> <!-- semver-check-comment --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
