andygrove commented on code in PR #47:
URL: https://github.com/apache/datafusion-java/pull/47#discussion_r3242450901
##########
core/src/main/java/org/apache/datafusion/SessionContext.java:
##########
@@ -160,6 +160,52 @@ public DataFrame readCsv(String path, CsvReadOptions
options) {
return new DataFrame(dfHandle);
}
+ public void registerJson(String name, String path) {
+ registerJson(name, path, new NdJsonReadOptions());
+ }
+
+ /**
+ * Register a newline-delimited JSON file (or directory of NDJSON files) as
a table with the
+ * supplied {@link NdJsonReadOptions}.
+ *
+ * @throws RuntimeException if registration fails (path not found, schema
inference error, etc.).
+ */
+ public void registerJson(String name, String path, NdJsonReadOptions
options) {
+ if (nativeHandle == 0) {
+ throw new IllegalStateException("SessionContext is closed");
+ }
+ registerJsonWithOptions(
+ nativeHandle,
+ name,
+ path,
+ options.toBytes(),
+ options.schema() != null ? serializeSchemaIpc(options.schema()) :
null);
+ }
+
+ /** Read a newline-delimited JSON file as a {@link DataFrame} without
registering it. */
+ public DataFrame readJson(String path) {
+ return readJson(path, new NdJsonReadOptions());
+ }
+
+ /**
+ * Read a newline-delimited JSON file as a {@link DataFrame} with the
supplied {@link
+ * NdJsonReadOptions}.
+ *
+ * @throws RuntimeException if the read fails.
+ */
+ public DataFrame readJson(String path, NdJsonReadOptions options) {
Review Comment:
please add null checks for args
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
