github-actions[bot] commented on PR #22300: URL: https://github.com/apache/datafusion/pull/22300#issuecomment-4469858951
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v53.1.0 (current) Built [ 94.032s] (current) Parsing datafusion v53.1.0 (current) Parsed [ 0.033s] (current) Building datafusion v53.1.0 (baseline) Built [ 89.274s] (baseline) Parsing datafusion v53.1.0 (baseline) Parsed [ 0.033s] (baseline) Checking datafusion v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.712s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 187.932s] datafusion Building datafusion-catalog v53.1.0 (current) Built [ 35.264s] (current) Parsing datafusion-catalog v53.1.0 (current) Parsed [ 0.024s] (current) Building datafusion-catalog v53.1.0 (baseline) Built [ 34.785s] (baseline) Parsing datafusion-catalog v53.1.0 (baseline) Parsed [ 0.024s] (baseline) Checking datafusion-catalog v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.170s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 71.923s] datafusion-catalog Building datafusion-expr v53.1.0 (current) Built [ 24.776s] (current) Parsing datafusion-expr v53.1.0 (current) Parsed [ 0.070s] (current) Building datafusion-expr v53.1.0 (baseline) Built [ 24.708s] (baseline) Parsing datafusion-expr v53.1.0 (baseline) Parsed [ 0.068s] (baseline) Checking datafusion-expr v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 1.410s] 222 checks: 220 pass, 2 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field TableScan.statistics_requests in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:2790 field TableScan.statistics_requests in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:2790 --- failure type_method_marked_deprecated: type method #[deprecated] added --- Description: A type method is now #[deprecated]. Downstream crates will get a compiler warning when using this method. ref: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-deprecated-attribute impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/type_method_marked_deprecated.ron Failed in: method datafusion_expr::logical_plan::TableScan::try_new in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:2866 method datafusion_expr::TableScan::try_new in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:2866 Summary semver requires new major version: 1 major and 1 minor checks failed Finished [ 52.615s] datafusion-expr Building datafusion-expr-common v53.1.0 (current) Built [ 17.623s] (current) Parsing datafusion-expr-common v53.1.0 (current) Parsed [ 0.017s] (current) Building datafusion-expr-common v53.1.0 (baseline) Built [ 17.513s] (baseline) Parsing datafusion-expr-common v53.1.0 (baseline) Parsed [ 0.017s] (baseline) Checking datafusion-expr-common v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.242s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 36.618s] datafusion-expr-common Building datafusion-optimizer v53.1.0 (current) Built [ 24.893s] (current) Parsing datafusion-optimizer v53.1.0 (current) Parsed [ 0.026s] (current) Building datafusion-optimizer v53.1.0 (baseline) Built [ 25.140s] (baseline) Parsing datafusion-optimizer v53.1.0 (baseline) Parsed [ 0.027s] (baseline) Checking datafusion-optimizer v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.201s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 51.948s] datafusion-optimizer Building datafusion-proto v53.1.0 (current) Built [ 50.172s] (current) Parsing datafusion-proto v53.1.0 (current) Parsed [ 0.128s] (current) Building datafusion-proto v53.1.0 (baseline) Built [ 50.046s] (baseline) Parsing datafusion-proto v53.1.0 (baseline) Parsed [ 0.129s] (baseline) Checking datafusion-proto v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 2.019s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 105.571s] datafusion-proto ``` </details> <!-- semver-check-comment --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
