sandugood opened a new pull request, #1723: URL: https://github.com/apache/datafusion-ballista/pull/1723
# Which issue does this PR close? Handles #1359, particularly this part: verify [if we can reuse instead] > (https://github.com/spiceai/spiceai/blob/348b7cc7eaac7eaebbce277e8569d8119989a921/crates/datafusion-optimizer-rules/src/physical_plan/hash_join_optimization.rs#L39) of creating our own rule for eliminating joins # Rationale for this change Handling cases of different physical types of joins and adding branching for different logical parts (i.e Left or LeftAnti) without adding separate AQE rule - adding logic straight into the `PropagateEmptyExecRule` # What changes are included in this PR? 1. Added `JoinInfo` struct to contain information about the join (both left and right part) 2. Added `as_join` function, which can be extended in the future to add support for other physical joins. Right now it handles both SortMerge and HashJoin 3. Reused `is_guaranteed_empty` from the Spice-AI implementation of eliminating empty joins. # Are there any user-facing changes? No # Were this changes tested? Yes, tests were included in both `propagate_empty.rs` and `join_info.rs` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
