kumarUjjawal commented on issue #22269: URL: https://github.com/apache/datafusion/issues/22269#issuecomment-4479320325
I think this issue should stay scoped to the one-arg float case. PostgreSQL’s two-arg form is a different case, so `round(125.2345, 3)` should not drive this fix. For DataFusion, the safer change is: keep decimal rounding as-is, keep float rounding with explicit scale as-is for now, and change only the one-arg float overload to ties-to-even, with targeted regression tests for 2.5, 3.5, -2.5, and -3.5. If we want stricter PostgreSQL behavior for round(double precision, int) or a separate explicit banker’s function, that should be a another issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
