mkleen commented on code in PR #22358: URL: https://github.com/apache/datafusion/pull/22358#discussion_r3265358348
########## datafusion/common/src/heap_size.rs: ########## @@ -32,12 +56,15 @@ use std::collections::HashMap; use std::fmt::Debug; use std::sync::Arc; -/// This is a temporary solution until <https://github.com/apache/datafusion/pull/19599> and -/// <https://github.com/apache/arrow-rs/pull/9138> are resolved. -/// Trait for calculating the size of various containers +/// Trait for computing how many bytes a value has allocated on the heap. Review Comment: I removed this now because the heapsize allocations in Datafusion already diverged from the once in arrow-rs and there is a good chance that this code continues to live here. ########## datafusion/common/src/heap_size.rs: ########## @@ -32,12 +56,15 @@ use std::collections::HashMap; use std::fmt::Debug; use std::sync::Arc; -/// This is a temporary solution until <https://github.com/apache/datafusion/pull/19599> and -/// <https://github.com/apache/arrow-rs/pull/9138> are resolved. -/// Trait for calculating the size of various containers +/// Trait for computing how many bytes a value has allocated on the heap. Review Comment: I removed this now because the heapsize estimations in Datafusion already diverged from the once in arrow-rs and there is a good chance that this code continues to live here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
